Set TCP keepalive on inbound clusterbus connections #9230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, A and B are two nodes in a cluster. When A is partitioned away, B will free the "struct clusterLink" which is used for send ping to A. But the corresponding "struct clusterLink" in A won't be freed. When partition heals, B uses a new clusterLink to send ping to A and A will create another new corresponding clusterLink. The older "struct clusterLink" above is still in the memory.
madolson
reviewed
Jul 14, 2021
Co-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>
madolson
reviewed
Jul 15, 2021
madolson
added
state:to-be-merged
Co-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>
madolson
changed the title
madolson
changed the title
madolson
changed the title
|
@madolson shall we backport this to 6.0 and 6.2? |
|
Backporting seems safe, it's very low risk and should help some edge cases. |
oranagra
pushed a commit
to oranagra/redis
that referenced
this pull request
Jul 20, 2021
Set TCP keepalive on inbound clusterbus connections to prevent memory leak (cherry picked from commit f03af47)
Merged
oranagra
pushed a commit
to oranagra/redis
that referenced
this pull request
Jul 21, 2021
Set TCP keepalive on inbound clusterbus connections to prevent memory leak (cherry picked from commit f03af47)
Merged
oranagra
pushed a commit
that referenced
this pull request
Jul 21, 2021
Set TCP keepalive on inbound clusterbus connections to prevent memory leak (cherry picked from commit f03af47)
oranagra
pushed a commit
that referenced
this pull request
Jul 21, 2021
Set TCP keepalive on inbound clusterbus connections to prevent memory leak (cherry picked from commit f03af47)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
Set TCP keepalive on inbound clusterbus connections to prevent memory leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue where an inbound link is disconnected but is never detected since the packet was dropped. This can cause a memory leak as the connection will not be detected through any other mechanism.
For example, A and B are two nodes in a cluster.
When A is partitioned away, B will free the "struct clusterLink" which is used for send ping to A. But the corresponding "struct clusterLink" in A won't be freed.
When partition heals, B uses a new clusterLink to send ping to A and A will create another new corresponding clusterLink. The older "struct clusterLink" above is still in the memory.